Skip to content

Internalization of OneToOne and ManyToOne Column classes - #2632

Merged
codemzs merged 2 commits into
dotnet:masterfrom
codemzs:lockdowncolumns
Feb 20, 2019
Merged

Internalization of OneToOne and ManyToOne Column classes#2632
codemzs merged 2 commits into
dotnet:masterfrom
codemzs:lockdowncolumns

Conversation

@codemzs

@codemzs codemzs commented Feb 19, 2019

Copy link
Copy Markdown
Member

fixes #2631

@codemzs codemzs self-assigned this Feb 19, 2019
@codemzs codemzs added the API Issues pertaining the friendly API label Feb 19, 2019
@codemzs codemzs added this to the 0219 milestone Feb 19, 2019
@codecov

codecov Bot commented Feb 19, 2019

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@a25763e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2632   +/-   ##
=========================================
  Coverage          ?   71.53%           
=========================================
  Files             ?      800           
  Lines             ?   141847           
  Branches          ?    16119           
=========================================
  Hits              ?   101475           
  Misses            ?    35922           
  Partials          ?     4450
Flag Coverage Δ
#Debug 71.53% <ø> (?)
#production 67.82% <ø> (?)
#test 85.73% <ø> (?)
Impacted Files Coverage Δ
...Microsoft.ML.Data/Transforms/ColumnBindingsBase.cs 72.53% <ø> (ø)
...L.Transforms/Text/WordHashBagProducingTransform.cs 51.7% <ø> (ø)

Comment thread src/Microsoft.ML.Transforms/GcnTransform.cs Outdated

@Ivanidzo4ka Ivanidzo4ka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yaeldekel yaeldekel left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs
codemzs merged commit 30df61a into dotnet:master Feb 20, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

API Issues pertaining the friendly API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Internalization of OneToOne and ManyToOne Column classes

4 participants